6423116741
0103c5bnet: move MAX_FEELER_CONNECTIONS into connman (Cory Fields)e700cd0Convert ForEachNode* functions to take a templated function argument rather than a std::function to eliminate std::function overhead (Jeremy Rubin)d1a2295Made the ForEachNode* functions in src/net.cpp more pragmatic and self documenting (Jeremy Rubin)98591c5net: move vNodesDisconnected into CConnman (Cory Fields)fa2f8bcnet: add nSendBufferMaxSize/nReceiveFloodSize to CConnection::Options (Cory Fields)a19553bnet: Introduce CConnection::Options to avoid passing so many params (Cory Fields)bafa5fcnet: Drop StartNode/StopNode and use CConnman directly (Cory Fields)e81a602net: pass CClientUIInterface into CConnman (Cory Fields)f60b905net: Pass best block known height into CConnman (Cory Fields)fdf69ffnet: move max/max-outbound to CConnman (Cory Fields)8a59369net: move semOutbound to CConnman (Cory Fields)bd72937net: move nLocalServices/nRelevantServices to CConnman (Cory Fields)be9c796net: move SendBufferSize/ReceiveFloodSize to CConnman (Cory Fields)63cafa6net: move send/recv statistics to CConnman (Cory Fields)adf5d4cnet: SocketSendData returns written size (Cory Fields)ee44fa9net: move messageHandlerCondition to CConnman (Cory Fields)960cf2enet: move nLocalHostNonce to CConnman (Cory Fields)551e088net: move nLastNodeId to CConnman (Cory Fields)6c19d92net: move whitelist functions into CConnman (Cory Fields)53347f0net: create generic functor accessors and move vNodes to CConnman (Cory Fields)c0569c7net: Add most functions needed for vNodes to CConnman (Cory Fields)8ae2dacnet: move added node functions to CConnman (Cory Fields)502dd3anet: Add oneshot functions to CConnman (Cory Fields)a0f3d3cnet: move ban and addrman functions into CConnman (Cory Fields)aaf018enet: handle nodesignals in CConnman (Cory Fields)b1a5f43net: move OpenNetworkConnection into CConnman (Cory Fields)02137f1net: Move socket binding into CConnman (Cory Fields)5b446ddnet: Pass CConnection to wallet rather than using the global (Cory Fields)8d58c4dnet: Pass CConnman around as needed (Cory Fields)d7349canet: Add rpc error for missing/disabled p2p functionality (Cory Fields)cd16f48net: Create CConnman to encapsulate p2p connections (Cory Fields)d93b14dnet: move CBanDB and CAddrDB out of net.h/cpp (Cory Fields)531214fgui: add NodeID to the peer table (Cory Fields)
Bitcoin Core integration/staging tree
What is Bitcoin?
Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built and tested, but is not guaranteed to be
completely stable. Tags are created
regularly to indicate new official, stable release versions of Bitcoin Core.
The contribution workflow is described in CONTRIBUTING.md.
The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set.
Developer IRC can be found on Freenode at #bitcoin-core-dev.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check
There are also regression and integration tests of the RPC interface, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: qa/pull-tester/rpc-tests.py
The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also subscribe to the mailing list.