6cf81b01b4
fe95f84542qa: Test .walletlock file is closed (João Barbosa)2e9e904a5dwallet: Close wallet env lock file (João Barbosa)22cdb6cf59wallet: Close dbenv error file db.log (João Barbosa)f20513bd71Tests: add unit tests for GetWalletEnv (Pierre Rochard)85c6263ddbTrivial: add doxygen-compatible comments relating to BerkeleyEnvironment (Pierre Rochard)f22d02f537Free BerkeleyEnvironment instances when not in use (Russell Yanofsky)0a9af2d4cbwallet: Create IsDatabaseLoaded function (Chun Kuan Lee)7751ea37b6Refactor: Move m_db pointers into BerkeleyDatabase (Russell Yanofsky)caf1146b13wallet: Add trailing wallet.dat when detecting duplicate wallet if it's a directory. (Chun Kuan Lee)34da2b7c76tests: add test case for loading copied wallet twice (Chun Kuan Lee)8965b6ab47wallet: Fix duplicate fileid (Chun Kuan Lee)16e5759455wallet: Refactor to use WalletLocation (João Barbosa)21693ff0b7wallet: Add WalletLocation utility class (João Barbosa)1c98a758d0No longer shutdown after encrypting the wallet (Andrew Chow)435df68c62Move BerkeleyEnvironment deletion from internal method to callsite (Andrew Chow)048fda2a66After encrypting the wallet, reload the database environment (Andrew Chow)f455979eb1Add function to close all Db's and reload the databae environment (Andrew Chow) Pull request description: This PR backports the following pull requests: - #12493 [wallet] Reopen CDBEnv after encryption instead of shutting down - #14350 Add WalletLocation class - #14320 [bugfix] wallet: Fix duplicate fileid detection - #14552 wallet: detecting duplicate wallet by comparing the db filename. - #11911 Free BerkeleyEnvironment instances when not in use - #15297 wallet: Releases dangling files on BerkeleyEnvironment::Close Tree-SHA512: 52d759bc4f140ca96e39b37746cc20e786741b08ddc658a87ea77fbcfbb481f1c7b75aba4fc57ca9bca8ca7154e535da1fdd650fd114873655cd85c490c79f14
Bitcoin Core integration/staging tree
What is Bitcoin?
Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built and tested, but is not guaranteed to be
completely stable. Tags are created
regularly to indicate new official, stable release versions of Bitcoin Core.
The contribution workflow is described in CONTRIBUTING.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py
The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also subscribe to the mailing list.