e2e4c2969b
tests: Test that PSBT_OUT_TAP_TREE is included correctly (Andrew Chow)4d42c3a240
psbt: Only include m_tap_tree if it has scripts (Andrew Chow)d810fde8ea
psbt: Change m_tap_tree to store just the tuples (Andrew Chow)a9419eff0c
tests: Test that PSBT_OUT_TAP_TREE is combined correctly (Andrew Chow)4abd2ab18e
psbt: Fix merging of m_tap_tree (Andrew Chow)1390c96c8e
[BugFix]: Do not allow deserializing PSBT with empty PSBT_OUT_TAP_TREE (Jeremy Rubin)9b438f06ec
refactor: revert m_next_resend to not be std::atomic (stickies-v)43ced0b436
wallet: only update m_next_resend when actually resending (stickies-v)fc8f2bfa3a
refactor: carve out tx resend timer logic into ShouldResend (stickies-v)a6fb674f96
refactor: remove unused locks for ResubmitWalletTransactions (stickies-v)5ad82a09b4
index: Improve BaseIndex::BlockUntilSyncedToCurrentChain reliability (Ryan Ofsky)997faf6b6c
contrib: Fix capture_output in getcoins.py (willcl-ark)7e0bcfbfef
p2p: ProcessHeadersMessage(): fix received_new_header (Larry Ruane)c97d924880
Correct sanity-checking script_size calculation (Pieter Wuille)da6fba6fe7
docs: Add 371 to bips.md (Andrew Chow) Pull request description: Will collect backports for rc2 as they become available. Currently: * https://github.com/bitcoin/bitcoin/pull/25858 * https://github.com/bitcoin/bitcoin/pull/26124 * https://github.com/bitcoin/bitcoin/pull/26149 * https://github.com/bitcoin/bitcoin/pull/26172 * https://github.com/bitcoin/bitcoin/pull/26205 * https://github.com/bitcoin/bitcoin/pull/26212 * https://github.com/bitcoin/bitcoin/pull/26215 ACKs for top commit: dergoegge: ACKe2e4c2969b
achow101: ACKe2e4c2969b
instagibbs: ACKe2e4c2969b
Tree-SHA512: b6374fe202561057dbe1430d4c40f06f721eb568f91e7275ae1ee7747edf780ce64620382d13ecc4b9571d931dc25d226af8284987cf35ff6a6182c5f64eb10c
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master
branch is regularly built (see doc/build-*.md
for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check
. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.