94f0adcc31
d38ade7bc409207bf425e05ee10b633b0aef4c36 qa: Use `sys.executable` when invoking other Python scripts (Hennadii Stepanov) Pull request description: This PR fixes the `rpc_signer.py` and `wallet_signer.py` functional tests on systems where `python3` is not available in the `PATH`, causing the shebang `#!/usr/bin/env python3` to fail. Here are logs on NetBSD 10.0: - without this PR: ``` $ python3.12 ./build/test/functional/test_runner.py rpc_signer.py wallet_signer.py Temporary test directory at /tmp/test_runner_₿_🏃_20241219_160538 Remaining jobs: [rpc_signer.py, wallet_signer.py --descriptors] 1/2 - rpc_signer.py failed, Duration: 1 s stdout: 2024-12-19T16:05:40.012000Z TestFramework (INFO): PRNG seed is: 1833166631173850775 2024-12-19T16:05:40.012000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1 2024-12-19T16:05:40.754000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 160, in try_rpc fun(*args, **kwds) File "/home/hebasto/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/authproxy.py", line 146, in __call__ raise JSONRPCException(response['error'], status) test_framework.authproxy.JSONRPCException: RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory (-1) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main self.run_test() File "/home/hebasto/dev/bitcoin/build/test/functional/rpc_signer.py", line 72, in run_test assert_raises_rpc_error(-1, 'fingerprint not found', File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 151, in assert_raises_rpc_error assert try_rpc(code, message, fun, *args, **kwds), "No exception raised" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/util.py", line 166, in try_rpc raise AssertionError( AssertionError: Expected substring not found in error message: substring: 'fingerprint not found' error message: 'RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory '. 2024-12-19T16:05:40.756000Z TestFramework (INFO): Stopping nodes 2024-12-19T16:05:40.873000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1 2024-12-19T16:05:40.873000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1/test_framework.log 2024-12-19T16:05:40.873000Z TestFramework (ERROR): 2024-12-19T16:05:40.873000Z TestFramework (ERROR): Hint: Call /home/hebasto/dev/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20241219_160538/rpc_signer_1' to consolidate all logs 2024-12-19T16:05:40.873000Z TestFramework (ERROR): 2024-12-19T16:05:40.873000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-12-19T16:05:40.873000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues 2024-12-19T16:05:40.873000Z TestFramework (ERROR): stderr: Remaining jobs: [wallet_signer.py --descriptors] 2/2 - wallet_signer.py --descriptors failed, Duration: 1 s stdout: 2024-12-19T16:05:40.014000Z TestFramework (INFO): PRNG seed is: 7530764367977090686 2024-12-19T16:05:40.014000Z TestFramework (INFO): Initializing test directory /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0 2024-12-19T16:05:40.526000Z TestFramework (ERROR): JSONRPC error Traceback (most recent call last): File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_framework.py", line 135, in main self.run_test() File "/home/hebasto/dev/bitcoin/build/test/functional/wallet_signer.py", line 66, in run_test self.test_valid_signer() File "/home/hebasto/dev/bitcoin/build/test/functional/wallet_signer.py", line 83, in test_valid_signer self.nodes[1].createwallet(wallet_name='hww', disable_private_keys=True, descriptors=True, external_signer=True) File "/home/hebasto/dev/bitcoin/test/functional/test_framework/test_node.py", line 935, in createwallet return self.__getattr__('createwallet')(wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup, external_signer) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/coverage.py", line 50, in __call__ return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/hebasto/dev/bitcoin/test/functional/test_framework/authproxy.py", line 146, in __call__ raise JSONRPCException(response['error'], status) test_framework.authproxy.JSONRPCException: RunCommandParseJSON error: process(/home/hebasto/dev/bitcoin/test/functional/mocks/signer.py enumerate) returned 127: env: python3: No such file or directory (-1) 2024-12-19T16:05:40.528000Z TestFramework (INFO): Stopping nodes 2024-12-19T16:05:40.645000Z TestFramework (WARNING): Not cleaning up dir /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0 2024-12-19T16:05:40.646000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0/test_framework.log 2024-12-19T16:05:40.646000Z TestFramework (ERROR): 2024-12-19T16:05:40.646000Z TestFramework (ERROR): Hint: Call /home/hebasto/dev/bitcoin/test/functional/combine_logs.py '/tmp/test_runner_₿_🏃_20241219_160538/wallet_signer_0' to consolidate all logs 2024-12-19T16:05:40.646000Z TestFramework (ERROR): 2024-12-19T16:05:40.646000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log. 2024-12-19T16:05:40.646000Z TestFramework (ERROR): https://github.com/bitcoin/bitcoin/issues 2024-12-19T16:05:40.646000Z TestFramework (ERROR): stderr: TEST | STATUS | DURATION rpc_signer.py | ✖ Failed | 1 s wallet_signer.py --descriptors | ✖ Failed | 1 s ALL | ✖ Failed | 2 s (accumulated) Runtime: 1 s ``` - with this PR: ``` $ python3.12 ./build/test/functional/test_runner.py rpc_signer.py wallet_signer.py Temporary test directory at /tmp/test_runner_₿_🏃_20241219_160011 Remaining jobs: [rpc_signer.py, wallet_signer.py --descriptors] 1/2 - rpc_signer.py passed, Duration: 2 s Remaining jobs: [wallet_signer.py --descriptors] 2/2 - wallet_signer.py --descriptors passed, Duration: 3 s TEST | STATUS | DURATION rpc_signer.py | ✓ Passed | 2 s wallet_signer.py --descriptors | ✓ Passed | 3 s ALL | ✓ Passed | 5 s (accumulated) Runtime: 3 s ``` ACKs for top commit: maflcko: lgtm ACK d38ade7bc409207bf425e05ee10b633b0aef4c36 stickies-v: ACK d38ade7bc409207bf425e05ee10b633b0aef4c36 . I have a minor concern about `sys.executable` not being guaranteed to return a valid Python path, but this patch seems good enough as is so no blocker. Tree-SHA512: 91fe0abc0b7e2b599c5562f8b225ba60f94c5bd6baa77d8df532155ef4d3ef6c6a862cee7f4a7f565ed4bb3251adcda813b4a4f79be1aa6a4ffdfda8b4e53415
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.