971952588d
513e2020a9guix: Remove unused `file` package (Hennadii Stepanov) Pull request description: The `file` utility has not been required since Guix builds were introduced in https://github.com/bitcoin/bitcoin/pull/15277. My Guix build: ``` feeb8da87994724878ac8a62a6e9bfb9b1ece855f336327c900214d84d0a2bb9 guix-build-513e2020a9ac/output/aarch64-linux-gnu/SHA256SUMS.part 216b287ffbff054a14e60e14b3376acb8cd41dd224223ecd508bd46efad020ba guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu-debug.tar.gz 3e68be5a329cbf5f389ca0dde51c1b1dd16b63ec26f42b8aa97dbd455ee3f30e guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu.tar.gz da2d239a78e7ceaa944bd20d15118577daf5cb3817cde4bfe39ea014707326bd guix-build-513e2020a9ac/output/arm-linux-gnueabihf/SHA256SUMS.part 0c05b2ab0cd048d4b3b66b97f433895ca0258a68485d641a1c7aaec198114a59 guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf-debug.tar.gz 8cf7ff862c9eccfa7ebfb573674485082b5b797f0a8e9ba058156d3131b144fd guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf.tar.gz 9464457cb7832b1805a25bb86cdc7c8670dd3c02333e229470d5348c587a73b8 guix-build-513e2020a9ac/output/arm64-apple-darwin/SHA256SUMS.part 21f0b343cfd5a85f5b563e92931b254874a6dfad21eec91d40b485320ea37a27 guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-codesigning.tar.gz e34a91173eae3b5ebb6dfa5ca39aa5bb782a2bfd30331edfa0075edda766ac7b guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.tar.gz 6c42015d14fb82f124450498299db15147ee3d93d5192f2fa45d700db9ef0fb9 guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.zip ddd176d8fcf325c23cb1d9c17933f651b26ce3ef13d1c4962460b3bfdb9fd7ff guix-build-513e2020a9ac/output/dist-archive/bitcoin-513e2020a9ac.tar.gz 92af97145e0dbeac11a49da48e567f3ee6e08c88c17aa434f10dc4ae13125a57 guix-build-513e2020a9ac/output/powerpc64-linux-gnu/SHA256SUMS.part fe980f2d4a6a6c567f447bd86221887ea3f9dcceb14a42e20f9cb8682ff66efe guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu-debug.tar.gz 41c9f8c46acafec1c80fc1727eddeb8e0373ef06ffc221b16af82b6d61b9c49a guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu.tar.gz 42051e97efd6178630c65bd398db075342d2c4722f97ec774b4e506b28f7e83b guix-build-513e2020a9ac/output/riscv64-linux-gnu/SHA256SUMS.part f136a82ee58d10db1360d3aa00e695c8e4017db483fe84080e8050efe4436042 guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu-debug.tar.gz 78d23a7b622e894fa150706a5981ef0bf5ec35b93caaaafdd4aa95c76689ca14 guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu.tar.gz 7faaa7151d85482a48c73416f0efc124f92fdf26ef232ec0dc9aa131661b2aa8 guix-build-513e2020a9ac/output/x86_64-apple-darwin/SHA256SUMS.part 13b1bb0026c2441903210f13e61be6220abb75f50dd775bb0bea3bc388ed047c guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-codesigning.tar.gz 80296525f4c797b24e0ac9617ef1e3d4edbce638be3dee823face9554ba9f373 guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.tar.gz 58a2a3f7335a61c68f7023aa6e2668a958ea2a4acf241c0c9968866ca5da1a21 guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.zip 511e2f63b1f25e7c4309d8328cd9fa09b8b65dbcce8124334f89445f127f1fd2 guix-build-513e2020a9ac/output/x86_64-linux-gnu/SHA256SUMS.part 6458af46a7960b668651c59a2a0fef9d44c3c17489fad06f92ca2c43a60b2b23 guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu-debug.tar.gz f259a3364bcc3a35346498fb224e061d37d30555aa263fe74bc45e701fb4c9a6 guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu.tar.gz 246ea6cb2218518c490f9a92bcd1dcb5589ed50f11b3713e4d2721990e655e39 guix-build-513e2020a9ac/output/x86_64-w64-mingw32/SHA256SUMS.part beb17556e14916e2af8463090c4f0787e16721961a88ef54975b61dde36d1503 guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-codesigning.tar.gz 85a46d84c0433a50410f1929babc1b22721e8ee7853e57ec5370a072c05146dc guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-debug.zip b7191d93cb1524cfd610cee6844119739b9301550b99babb0cefe10546e53445 guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-setup-unsigned.exe f6615296b46fd064e02fa9b4007e5d59c255595530fc91a8303e417579a7fe80 guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-unsigned.zip ``` ACKs for top commit: janb84: Code review and Tested ACK [513e202](513e2020a9) fanquake: ACK513e2020a9Tree-SHA512: 9c684ad473ba6b298dd50c6fb2fb274aa83f5fbe54f6c3d12cd3b30cbc3f77390966ce9ac3be3f675948642743bac4fb45dcda661400bdfde4f347d300478a2a
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.