highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-27 17:31:40 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
fanquake be44332803
Merge bitcoin/bitcoin#28191: refactor: Remove unused MessageStartChars parameters from BlockManager methods 
fa69e3a95c452c2ba3221b17c19fba5993b5d073 Remove unused MessageStartChars parameters from BlockManager methods (MarcoFalke)

Pull request description:

  Seems odd to expose these for mocking, when it is not needed.

  Fix this by removing the the unused parameters and use the already existing member field instead.

ACKs for top commit:
  Empact:
    utACK fa69e3a95c452c2ba3221b17c19fba5993b5d073
  dergoegge:
    utACK fa69e3a95c452c2ba3221b17c19fba5993b5d073

Tree-SHA512: 7814e9560abba8d9c0926bcffc70f92e502d22f543af43671248f6fcd1433f35238553c0f05123fde6d8e0f80261af0ab0500927548115153bd68d57fe2da746
2023-08-07 10:57:39 +02:00
..
abort.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
abort.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
blockmanager_args.cpp
refactor: Move stopafterblockimport handling out of blockstorage
2023-07-11 12:00:57 +02:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
Merge bitcoin/bitcoin#28191: refactor: Remove unused MessageStartChars parameters from BlockManager methods
2023-08-07 10:57:39 +02:00
blockstorage.h
Merge bitcoin/bitcoin#28191: refactor: Remove unused MessageStartChars parameters from BlockManager methods
2023-08-07 10:57:39 +02:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
…
chainstate.cpp
Move block-arrival information / preciousblock counters to ChainstateManager
2023-07-14 17:09:06 -04:00
chainstate.h
validation: Stricter assumeutxo error handling in LoadChainstate
2023-06-15 15:11:32 -04:00
chainstatemanager_args.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
chainstatemanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
coin.cpp
…
coin.h
…
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
…
connection_types.cpp
…
connection_types.h
…
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
refactor: init indexes, decouple 'Start()' from the creation step
2023-07-07 19:31:27 -03:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
…
eviction.cpp
…
eviction.h
…
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
kernel_notifications.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
kernel_notifications.h
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
mempool_args.cpp
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
miner.h
Add public Boost headers explicitly
2023-05-31 15:43:01 +01:00
mini_miner.cpp
Mitigate timeout in CalculateTotalBumpFees
2023-06-01 18:04:44 -04:00
mini_miner.h
Implement Mini version of BlockAssembler to calculate mining scores
2023-03-30 17:03:04 -04:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
…
peerman_args.cpp
refactor: set ignore_incoming_txs in ApplyArgsManOptions
2023-07-25 14:34:06 +01:00
peerman_args.h
[net processing] Introduce PeerManager options
2023-07-24 18:30:59 +02:00
psbt.cpp
…
psbt.h
…
README.md
…
transaction.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
transaction.h
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
utxo_snapshot.cpp
refactor: Add path argument to FindSnapshotChainstateDir
2023-05-30 16:52:48 +02:00
utxo_snapshot.h
refactor: Add path argument to FindSnapshotChainstateDir
2023-05-30 16:52:48 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.