9a05b45da6
fa061bfcdb0caea240fd15bcc309e7847132a4ff Remove create options from wallet tool (MarcoFalke)
fa2125e7b8e368d8fae8a3d56cdb54b7f9d0d9c9 Remove unused IsSingleKey (MarcoFalke)
fab5e2a0948a965c29206f2a051d5fe22d49378b doc: Remove note about bdb wallets (MarcoFalke)
eeeef88d46feda06feda597152329533d0aad212 doc: fix typo in abortrescan rpc (MarcoFalke)
fa7e5c15a795852972a322fb9605643d4cef3471 Remove unused LegacyDataSPKM::DeleteRecords() (MarcoFalke)
ffff949472985c70e82aa5eb5671c1c55c073d72 remove NotifyWatchonlyChanged (MarcoFalke)
fa62a013a558338dc6ee5fb4cfd6fc7c782c301b remove dead flush() (MarcoFalke)
fa5f3e62c8801cca80997cfb046c13983e0876e7 vcpkg: Remove bdb (MarcoFalke)
Pull request description:
This deletes some dead code
ACKs for top commit:
Sjors:
ACK fa061bfcdb0caea240fd15bcc309e7847132a4ff if CI is also happy
rkrux:
utACK fa061bf
Tree-SHA512: 6c0b0705caa4ad024e6b921bd7f65aaa055d1f12f7884cd61823cbf0c32e46697ddbdaa209ab449d6a1df9761ce5d53763e25f26e4c36ce4c685b7524f5a3dd9
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.