d7ed2840ac
9fa4076b20test: Test merging implicit PSBTv0 with explicit PSBTv0 (w0xlt)1660c18232doc: Release notes for psbtv2 (Ava Chow)470e52a5f8fuzz: Enforce additional version invariants in PSBT fuzzer (Antoine Poinsot)5bd0579c09test: Tests for PSBT AddInput and AddOutput (Ava Chow)b8b6e7f0c2tests: Add PSBT unit test for ComputeTimeLock (Ava Chow)0bc1c2e508tests: Add test vectors from BIP 370 (Ava Chow)e0e4dbdeb5psbt: Change default psbt version to 2 (Ava Chow)bcc1dca77bAdd psbt_version to PSBT RPCs and default to v2 (Ava Chow)ab38c30195Implement PSBTv2 field merging (Ava Chow)93e339e29fImplement PSBTv2 AddInput and AddOutput (Ava Chow)b39c86ae60Allow specifying PSBT version in constructor (Ava Chow)dcc9a3c8dfImplement PSBTv2 in decodepsbt (Ava Chow)5770dbd39fAdd PSBT::ComputeLockTime() (Ava Chow)863cf47b33Update test_framework/psbt.py for PSBTv2 (Ava Chow)925161eaf0Implement PSBTv2 fields de/ser (Ava Chow)d9cf658ee0Restrict joinpsbts to PSBTv0 only (Ava Chow)3da0e16012Replace PSBT.tx with PSBT::GetUnsignedTx and PSBT::GetUniqueID (Ava Chow)c568624ff2psbt: Return std::optional from PrecomputePSBTData (Ava Chow)092de4f1f6Replace PSBT::GetInputUTXO with PSBTInput::GetUTXO (Ava Chow)82c9fe3179psbt: Use PSBTInput and PSBTOutput fields instead of accessing global tx (Ava Chow)95897507e9psbt: AddInput and AddOutput should take only PSBTInput and PSBTOutput (Ava Chow)1b7d323a72Add PSBTInput::GetOutPoint (Ava Chow)543d3e1cdcpsbt: add PSBTv2 global tx fields (Ava Chow)c01c7f068cpsbt: Remove default constructor (Ava Chow)9671aa08c2psbt: add tx input and output fields in PSBTInput and PSBTOutput (Ava Chow)990b084f11Have PSBTInput and PSBTOutput know the PSBT's version (Ava Chow)7eacc21ff6psbt: make PSBT structs into classes (Ava Chow)f926c326bbgui: Store PSBT in std::optional in PSBTOperationsDialog (Ava Chow)1e2d146b47psbt: Refactor duplicate key lookup and size checks (Ava Chow)88384180d3test: PSBTs should roundtrip through RPCs that do nothing (Ava Chow)001877500dtest: construct psbt with unknown field programmatically (David Gumberg)0cb884e6dfpsbt: Fill hash preimages and taproot builder from SignatureData (Ava Chow) Pull request description: BIP 370 PSBTv2 introduces several new fields and different invariants for PSBT. This PR implements those new fields and restructures the PSBT implementation to match PSBTv2 but still remain compatible with PSBTv0. ACKs for top commit: nervana21: re-ACK9fa4076b20theStack: re-ACK9fa4076b20w0xlt: ACK9fa4076b20Tree-SHA512: ab0a5ada4fa5fca27ba9ec9c291a44b30e69d6db11971957572d86c58c71c4caa4557dc25f403e1170ba4fac751306d074cc582defefc6e2fdd37be51c3d9dd0
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.