f7144b24be
466e4df3fbassert_mempool_contents: assert not duplicates expected (Greg Sanders)ea5db2f269functional: only generate required blocks for test (Greg Sanders)d033acb608fuzz: package_eval: let fuzzer run out input in main tx creation loop (Greg Sanders)ba35a570c5CheckEphemeralSpends: return boolean, and set child state and txid outparams (Greg Sanders)cf0cee1617func: add note about lack of 1P1C propagation in tree submitpackage (Greg Sanders)8424290304unit test: ephemeral_tests is using a dust relay rate, not minrelay (Greg Sanders)d9cfa5fc4eCheckEphemeralSpends: no need to iterate inputs if no parent dust (Greg Sanders)87b26e3dc0func: rename test_free_relay to test_no_minrelay_fee (Greg Sanders)e5709a4a41func: slight elaboration on submitpackage restriction (Greg Sanders)08e969bd10RPC: only enforce dust rules on priority when standardness active (Greg Sanders)ca050d12e7unit test: adapt to changing MAX_DUST_OUTPUTS_PER_TX (Greg Sanders)7c3490169cfuzz: package_eval: move last_tx inside txn ctor (Greg Sanders)445eaed182fuzz: use optional status instead of should_rbf_eph_spend (Greg Sanders)4dfdf615b9fuzz: remove unused TransactionsDelta validation interface (Greg Sanders)09ce926e4afunc: cleanup reorg test comment (Greg Sanders)768a0c1889func: cleanup test_dustrelay comments (Greg Sanders)bedca1cb66fuzz: Directly place transactions in vector (Greg Sanders)c041ad6eccfuzz: explain package eval coin tracking better (Greg Sanders)bc0d98ea61fuzz: remove dangling reference to GetEntry (Greg Sanders)15b6cbf07funit test: make dust index less magical (Greg Sanders)5fbcfd12b8unit test: assert txid returned on CheckEphemeralSpends failures (Greg Sanders)ef94d84b4ebench: remove unnecessary CMTxn constructors (Greg Sanders)c5c10fd317ephemeral policy doxygen cleanup (Greg Sanders)dd9044b8d4ephemeral policy: IWYU (Greg Sanders)c6859ce2deMove+rename GetDustIndexes -> GetDust (Greg Sanders)62016b3230Use std::ranges for ephemeral policy checks (Greg Sanders)3ed930a1f4Have HasDust and PreCheckValidEphemeralTx take CTransaction (Greg Sanders)04a614bf9aRename CheckValidEphemeralTx to PreCheckEphemeralTx (Greg Sanders)cbf1a47d60CheckEphemeralSpends: only compute txid of tx when needed (Greg Sanders) Pull request description: Follow-up to https://github.com/bitcoin/bitcoin/pull/30239 Here are the parent PR's comments that should be addressed by this PR: https://github.com/bitcoin/bitcoin/pull/30239/files#r1834529646 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831247308 https://github.com/bitcoin/bitcoin/pull/30239/files#r1832622481 https://github.com/bitcoin/bitcoin/pull/30239/files#r1831195216 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1835805164 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834639096 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834624976 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834619709 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834610434 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834504436 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834500036 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832985488 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830929809 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832376920 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832755799 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832492686 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832980576 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832784278 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1837989979 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830996993 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830997947 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830012890 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830037288 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1830977092 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832622481 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1834726168 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1832453654 https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1848488226 ACKs for top commit: naumenkogs: ACK466e4df3fbhodlinator: ACK466e4df3fbtheStack: lgtm ACK466e4df3fbglozow: utACK466e4df3fbTree-SHA512: 89106f695755c238b84e0996b89446c0733e10a94c867f656d516d26697d2efe38dfc332188b8589a0a26a3d2bd2c88c6ab70c108e187ce5bfcb91bbf3fb0391
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.