highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-02 03:02:35 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
Ryan Ofsky c92fd63886
Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors 
61c569ab6069d04079a0831468eb713983919636 refactor: decouple early return commands from AppInit (furszy)
4927167f855f8ed3bbf6d2766f61229f742e632a gui: return EXIT_FAILURE on post-init fatal errors (furszy)
3b2c61e8198bcefb1c2343caff1d705951026cc4 Return EXIT_FAILURE on post-init fatal errors (furszy)
3c06926cf21dcca3074ef51506f556b2286c299b refactor: index: use `AbortNode` in fatal error helper (Sebastian Falbesoner)
9ddf7e03a35592617a016418fd320cc93c8d1abd move ThreadImport ABC error to use AbortNode (furszy)

Pull request description:

  It seems odd to return `EXIT_SUCCESS` when the node aborted execution due a fatal internal error
  or any post-init problem that triggers an unrequested shutdown.

  e.g. blocks or coins db I/O errors, disconnect block failure, failure during thread import (external
  blocks loading process error), among others.

ACKs for top commit:
  TheCharlatan:
    ACK 61c569ab6069d04079a0831468eb713983919636
  ryanofsky:
    Code review ACK 61c569ab6069d04079a0831468eb713983919636
  pinheadmz:
    ACK 61c569ab6069d04079a0831468eb713983919636
  theStack:
    Code-review ACK 61c569ab6069d04079a0831468eb713983919636

Tree-SHA512: 18a59c3acc1c6d12cbc74a20a401e89659740c6477fccb59070c9f97922dfe588468e9e5eef56c5f395762187c34179a5e3954aa5b844787fa13da2e666c63d3
2023-06-12 12:54:49 -04:00
..
blockmanager_args.cpp
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
move ThreadImport ABC error to use AbortNode
2023-06-08 16:38:36 -03:00
blockstorage.h
index: Enable reindex-chainstate with active indexes
2023-05-17 11:14:28 -04:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
…
chainstate.cpp
kernel: Add progress method to notifications
2023-05-20 12:03:26 +02:00
chainstate.h
doc: add explanation for fail_on_insufficient_dbcache
2023-02-24 15:11:27 -05:00
chainstatemanager_args.cpp
refactor: Add stop_at_height option in ChainstateManager
2023-05-30 16:52:47 +02:00
chainstatemanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
coin.cpp
…
coin.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
refactor, txdb: Add CoinsViewOptions struct
2023-02-10 04:39:11 -04:00
connection_types.cpp
…
connection_types.h
…
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
Return EXIT_FAILURE on post-init fatal errors
2023-06-09 17:52:23 -03:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
refactor, dbwrapper: Add DBParams and DBOptions structs
2023-02-10 04:39:11 -04:00
eviction.cpp
…
eviction.h
…
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors
2023-06-12 12:54:49 -04:00
kernel_notifications.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel_notifications.h
kernel: Add warning method to notifications
2023-05-20 12:03:28 +02:00
mempool_args.cpp
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
miner.h
Add public Boost headers explicitly
2023-05-31 15:43:01 +01:00
mini_miner.cpp
Mitigate timeout in CalculateTotalBumpFees
2023-06-01 18:04:44 -04:00
mini_miner.h
Implement Mini version of BlockAssembler to calculate mining scores
2023-03-30 17:03:04 -04:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
…
psbt.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.h
…
README.md
…
transaction.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
transaction.h
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
p2p, refactor: Switch to enum class for ReconciliationRegisterResult
2022-11-14 11:37:28 +02:00
utxo_snapshot.cpp
refactor: Add path argument to FindSnapshotChainstateDir
2023-05-30 16:52:48 +02:00
utxo_snapshot.h
refactor: Add path argument to FindSnapshotChainstateDir
2023-05-30 16:52:48 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.