fe3d2be1d6
bb00fd2142test: use dynamic ports and add coverage in feature_bind_port_discover (b-l-u-e)4f19508ae7test: dont connect nodes in feature_bind_port_discover (b-l-u-e)b8827ce619net: Fix Discover() not running when using -bind=0.0.0.0:port (b-l-u-e) Pull request description: This PR fixes two related issues with address discovery when using explicit bind addresses in Bitcoin Core: - #31293 - #31336 When using `-bind=0.0.0.0:port` (or `-bind=::`), the `Discover()` function was not being executed because the code only checked the `bind_on_any` flag. This led to two problems: - The node would not discover its own local addresses if an explicit "any" bind was used. - The functional test `feature_bind_port_discover.py` would fail, as it expects local addresses to be discovered in these cases. This PR: 1. Checks both `bind_on_any` and any bind addresses using `IsBindAny()` Ensures `Discover()` runs when binding to 0.0.0.0 or ::, even if specified explicitly. 2. Ensures correct address discovery The node will now discover its own addresses when using explicit "any" binds, matching user expectations and fixing the test. 3. Maintains backward compatibility The semantic meaning of `bind_on_any` is preserved as defined in `net.h`: > "True if the user did not specify -bind= or -whitebind= and thus we should bind on 0.0.0.0 (IPv4) and :: (IPv6)" 4. Updates the test to use dynamic ports The functional test `feature_bind_port_discover.py` is updated to use dynamic ports instead of hardcoded ones, improving reliability. References - Implementation follows the approach proposed in my [review comment on #31492](https://github.com/bitcoin/bitcoin/pull/31492#issuecomment-2941773645). Closes #31293 The #31336 has the overall test failure and requires both this PR and #33362 to be fully resolved. ACKs for top commit: NicolaLS: tested ACKbb00fd2142pinheadmz: ACKbb00fd2142vasild: ACKbb00fd2142achow101: ACKbb00fd2142Tree-SHA512: 6f1b0b29cc539e4b49b3594f9ad70be90cfff28e31497a8b85e11d8a2509faaa8ca803e542ea3280588ece5a065c4c54193cec87cad221f1abae34d8b13cfdc5
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.