b2f88b53e0
de7c3587cddoc: Update add checksum instructions in tutorial (Ben Westgate)2a46e94a16doc: Update multisig-tutorial.md to use multipath descriptors (Ben Westgate) Pull request description: ### Summary Update `doc/multisig-tutorial.md` to use multipath descriptor format instead of separate external/internal descriptors. The tutorial now: - extracts a single `xpub_n` per participant - constructs a multipath `wsh(sortedmulti(...))` descriptor with `<0;1>` change index semantics - uses `getdescriptorinfo` to compute descriptor checksum - explains that `importdescriptors` expands the multipath descriptor into internal and external descriptors - update `/test/functional/wallet_multisig_descriptor_psbt.py` functional test / documentation to use multi-path descriptors --- ### Motivation A single multipath descriptor is the most convenient pattern for multisig; our documentation should use it. --- ### What changed - replaced extraction of `external_xpub_n` and `internal_xpub_n` with extraction of a single `xpub_n` - removed instructions to create and import separate external/internal descriptors - added instructions to build a multipath `wsh(sortedmulti(...))` descriptor and derive checksum with `getdescriptorinfo` - checksum field is parsed and appended as the multipath descriptor is not the canonical "desc" output - clarified that `importdescriptors` automatically expands multipath descriptors into internal and external forms - similar changes to the functional test: wallet_multisig_descriptor_psbt. --- ### Testing I have run the updated shell snippets and confirmed the multipath descriptor produces the same `listdescriptors` output after importing as the two descriptor method in bitcoin:master. --- ### Related issues / PRs This tutorial change references the multipath descriptor consolidation (see commit / PR referenced in the change). The commit message points to bitcoin#22838 as the upstream change that enables this behavior. --- ### Release note (for changelog) Documentation: update multisig tutorial and multisig functional test to use multipath descriptors ACKs for top commit: Sjors: utACKde7c3587cdkannapoix: Core review ACK:de7c3587cdachow101: ACKde7c3587cdrkrux: crACKde7c3587cdTree-SHA512: ca7275d8ad04922b3fa8d2a3084ff96aa2104265f1fc2f749814dd16776351ab692d67e7e643d08052f7492e3eaa1a9a4dfe3470163e57939a49f782d3df511a
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.